feat: simplify zeroizing and add test to DHKE #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronFeickert
force-pushed
the
dhke-zeroize
branch
from
8f99926 to
1f77623
Compare
AaronFeickert
changed the title
ZeroizeOnDrop and test to DHKE
SWvheerden
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the implementation of zeroizing support for Diffie-Hellman key exchanges and improves test coverage.
Currently, the
DiffieHellmanSharedSecretstruct has manual implementations ofzeroizeanddropto handle zeroizing. Now that we have a more modern version ofzeroizeas a dependency, we can do better. This PR uses that crate'sZeroizeandZeroizeOnDropderived traits to handle this more cleanly. It also adds a sanity check that the byte representations of both sides of a key exchange match, which improves test coverage.Partially addresses #196.