Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly clippy fails on supposed recursion #220

Closed
AaronFeickert opened this issue Feb 2, 2024 · 0 comments · Fixed by #221
Closed

Nightly clippy fails on supposed recursion #220

AaronFeickert opened this issue Feb 2, 2024 · 0 comments · Fixed by #221

Comments

@AaronFeickert
Copy link
Contributor

Nightly clippy currently breaks CI, as it incorrectly thinks that the commitment PartialEq implementation recurses. This doesn't happen on stable.
@AaronFeickert AaronFeickert mentioned this issue Feb 2, 2024
Merged
sdbondi added a commit that referenced this issue Feb 6, 2024
@sdbondi
ci: fix lint error (#221)
9769068 
Nightly `clippy` incorrectly reports that the commitment `PartialEq`
[implementation](https://github.com/tari-project/tari-crypto/blob/017bb2cde069fc8a1b1a6014f339e59dc7fd6ca7/src/commitment.rs#L157-L161)
recurses. Changing the syntax to use `==` seems to fix this and does the
same thing.

Closes #220.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: fix lint error AaronFeickert/tari-crypto
1 participant
@AaronFeickert