Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize range proof tests #200

Closed
AaronFeickert opened this issue Aug 17, 2023 · 0 comments · Fixed by #201
Closed

Optimize range proof tests #200

AaronFeickert opened this issue Aug 17, 2023 · 0 comments · Fixed by #201

Comments

@AaronFeickert
Copy link
Contributor

AaronFeickert commented Aug 17, 2023 •
edited
Loading

Range proof tests slow down the overall testing process, which currently takes 10 minutes on CI. This is because of a large parameter space that is used relating to things like extension degrees, bit lengths, and aggregation factors. This can be optimized to minimize the number of parameters needed to properly exercise the desired functionality in each test.

Similar optimizations were done back in #144 as well.
@AaronFeickert AaronFeickert mentioned this issue Aug 23, 2023
Merged
SWvheerden pushed a commit that referenced this issue Oct 25, 2023
@AaronFeickert
test: optimize range proof tests (#201)
ea71092 
Tests are currently slow, mainly due to the parameters used in range
proof tests. This PR simplifies these parameters to speed up tests while
still exercising the required functionality.

Closes #200.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: optimize range proof tests AaronFeickert/tari-crypto
1 participant
@AaronFeickert