Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Invalid Stripping for Email Message ID Parsing #427

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Jan 19, 2024

Describe the change
This change modifies the ScanEmail class in the strelka scanner module. The update involves a minor alteration where the message_id field is extracted from the email header without the surrounding angle brackets (<>) by using .strip rather than simply the removal of the first and last character.

The message_id to be parsed out is:
<DS7PR03MB5640AD212589DFB7CE58D90CFBEB9@DS7PR03MB5640.namprd03.prod.outlook.com>

Prior to fix, the message_id looked like this:
"message_id": "S7PR03MB5640AD212589DFB7CE58D90CFBEB9@DS7PR03MB5640.namprd03.prod.outlook.co"

After the fix, the message_id looks like this:
"message_id": "DS7PR03MB5640AD212589DFB7CE58D90CFBEB9@DS7PR03MB5640.namprd03.prod.outlook.com"

I did a bad job originally parsing it.

Describe testing procedures
scan_test_email.py was modified to pass based on the change

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer marked this pull request as ready for review January 19, 2024 20:44
@phutelmyer phutelmyer merged commit bfafcff into master Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant