Fix for Invalid Stripping for Email Message ID Parsing #427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This change modifies the
ScanEmail
class in the strelka scanner module. The update involves a minor alteration where themessage_id
field is extracted from the email header without the surrounding angle brackets (<>) by using.strip
rather than simply the removal of the first and last character.The message_id to be parsed out is:
<DS7PR03MB5640AD212589DFB7CE58D90CFBEB9@DS7PR03MB5640.namprd03.prod.outlook.com>
Prior to fix, the message_id looked like this:
"message_id": "S7PR03MB5640AD212589DFB7CE58D90CFBEB9@DS7PR03MB5640.namprd03.prod.outlook.co"
After the fix, the message_id looks like this:
"message_id": "DS7PR03MB5640AD212589DFB7CE58D90CFBEB9@DS7PR03MB5640.namprd03.prod.outlook.com"
I did a bad job originally parsing it.
Describe testing procedures
scan_test_email.py
was modified to pass based on the changeSample output
N/A
Checklist