Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GO Dockerfile build error on some deployments by adding missing forward slash (/) to COPY command #367

Merged
merged 3 commits into from
Apr 20, 2023

Conversation

phutelmyer
Copy link
Contributor

Describe the change
When using the COPY command with more than one source file, the destination must be a directory and end with a forward slash (/). The original Dockerfiles for fileshot, filestream, frontend, manager, and oneshot did not include the forward slash, which would result in an error when building the Docker images (In GitHub Actions). This PR adds the missing forward slash to the COPY command, fixing the error.

Describe testing procedures
I tested the changes by building the Docker images for fileshot, filestream, frontend, manager, and oneshot both locally and using GitHub Actions. I verified that the images were built successfully and that the applications were functioning properly.

Sample output
N/A.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Apr 20, 2023
@phutelmyer phutelmyer merged commit fdf01fe into master Apr 20, 2023
@phutelmyer phutelmyer deleted the go-dockerfile-build-fix branch May 22, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant