Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds keyword to js scanner to scan ECMA6 compliant js (#33) #363

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

cameron-dunn-sublime
Copy link
Contributor

@cameron-dunn-sublime cameron-dunn-sublime commented Apr 10, 2023

Describe the change
Include a summary of the change (with required dependencies), any issues it fixes, and relevant motivation and context.

Originally implemented here: sublime-security#33. No merge conflicts (although that fork does have some moved around scanner config files)

Credit to @alexk307 for the change!

Describe testing procedures
I tested with an extremely minimal file test.js with contents:

let foo = 'bar'

Without this change no yara flavor is returned, and with this change the flavor javascript_file is returned.

Sample output
If this change modifies Strelka's output, then please include a sample of the output here.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@cameron-dunn-sublime cameron-dunn-sublime marked this pull request as ready for review April 11, 2023 00:25
@phutelmyer phutelmyer added the enhancement New feature or request label Apr 17, 2023
@phutelmyer
Copy link
Contributor

This looks good. I'll test it out and merge it in. Thanks @cameron-dunn-sublime and @alexk307 :)

@phutelmyer
Copy link
Contributor

Tested. No issues. Thank you for your contribution!

@phutelmyer phutelmyer merged commit d6a1b8a into target:master Apr 18, 2023
@cameron-dunn-sublime cameron-dunn-sublime deleted the cd.target.es6-js branch April 18, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants