Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Passwords File to Additional Scanners #334

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Feb 22, 2023

Describe the change
Prior to this request, only the ScanZip scanner was enabled to use a provisioned password file (default: passwords.dat). As ScanZip does not perform any password extraction, and instead waits for ScanEncryptedZip, this meant that the passwords file was never used. By enabling the password_file for ScanEncryptedZip, we are now attempting to open encrypted zip files with the provided password file, prior to brute forcing (if enabled).

As the password file functionality also exists in ScanEncryptedDoc, that has also been enabled by default.

Describe testing procedures
Started a local Strelka cluster and passed several password encrypted zip files through the Web UI. Prior to this change

Prior to fix (ScanEncryptedZip)
image

After fix (ScanEncryptedZip)
image

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer merged commit f5816b9 into master Feb 22, 2023
@phutelmyer phutelmyer deleted the encrypted_zip_password_file branch February 22, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant