Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ScanBITS references #308

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Removing ScanBITS references #308

merged 1 commit into from
Feb 2, 2023

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Feb 2, 2023

Describe the change
Per issue #305, the BITS scanner is to be removed due to dependency issues.

This change removes all references to the BITS Scanner.

Describe testing procedures
docker-compose -f build/docker-compose.yaml build --build-arg CONFIG_TESTS=true backend

#21 3.769 ============================= test session starts ==============================
...
#21 3.769 tests/test_distribute.py .
#21 3.893 tests/test_required_for_scanner.py .
#21 3.897 tests/test_scan_base64.py .
#21 3.900 tests/test_scan_base64_pe.py .
#21 3.903 tests/test_scan_batch.py .
#21 3.950 tests/test_scan_bmp_eof.py .
#21 3.953 tests/test_scan_bzip2.py .
#21 3.957 tests/test_scan_capa.py ...
#21 20.03 tests/test_scan_ccn.py .
#21 20.04 tests/test_scan_delay.py .
#21 21.05 tests/test_scan_dmg.py ...
#21 21.12 tests/test_scan_docx.py .
#21 21.42 tests/test_scan_elf.py .
#21 21.49 tests/test_scan_email.py .
#21 21.57 tests/test_scan_encrypted_doc.py ....
#21 25.15 tests/test_scan_encrypted_zip.py ..
#21 25.60 tests/test_scan_entropy.py .
#21 25.60 tests/test_scan_exception.py .
#21 25.61 tests/test_scan_exiftool.py ..
#21 25.96 tests/test_scan_footer.py ..
#21 25.97 tests/test_scan_gif.py .
#21 25.97 tests/test_scan_gzip.py .
#21 25.97 tests/test_scan_hash.py .
#21 25.98 tests/test_scan_header.py ..
#21 25.98 tests/test_scan_html.py ..
#21 25.99 tests/test_scan_ini.py .
#21 26.00 tests/test_scan_iso.py .
#21 26.00 tests/test_scan_javascript.py ..
#21 26.04 tests/test_scan_jpeg.py ..
#21 26.08 tests/test_scan_json.py .
#21 26.08 tests/test_scan_libarchive.py ......
#21 26.11 tests/test_scan_lnk.py .
#21 26.11 tests/test_scan_lzma.py .
#21 26.11 tests/test_scan_macho.py .
#21 26.13 tests/test_scan_manifest.py .
#21 26.13 tests/test_scan_msi.py .
#21 26.31 tests/test_scan_nf.py ....
#21 26.41 tests/test_scan_ocr.py ...
#21 92.02 tests/test_scan_ole.py ....
#21 92.04 tests/test_scan_pcap.py ..
#21 92.99 tests/test_scan_pdf.py .
#21 93.05 tests/test_scan_pe.py .
#21 93.05 tests/test_scan_pgp.py ....
#21 93.07 tests/test_scan_plist.py .
#21 93.07 tests/test_scan_png_eof.py ...
#21 93.08 tests/test_scan_qr.py ...
#21 93.26 tests/test_scan_rar.py .
#21 93.28 tests/test_scan_seven_zip.py .....
#21 108.7 tests/test_scan_strings.py .
#21 108.7 tests/test_scan_tar.py .
#21 108.7 tests/test_scan_tlsh.py .
#21 108.7 tests/test_scan_upx.py .
#21 108.8 tests/test_scan_url.py ..
#21 108.8 tests/test_scan_vhd.py ..
#21 108.8 tests/test_scan_x509.py ..
#21 108.8 tests/test_scan_xl4ma.py .
#21 108.9 tests/test_scan_xml.py .
#21 108.9 tests/test_scan_yara.py .
#21 108.9 tests/test_scan_zip.py ..
....
#21 119.0 ======================= 166 passed, 4 warnings in 9.09s ========================

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer requested a review from ryanohoro February 2, 2023 14:16
Copy link
Collaborator

@ryanohoro ryanohoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phutelmyer phutelmyer merged commit 05fa66e into master Feb 2, 2023
@phutelmyer phutelmyer deleted the scanbits-delete branch February 3, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants