-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style Automation #304
Merged
Merged
Style Automation #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phutelmyer
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reference to mpy
use in the proposed README change which is not active in this PR, but is intended in the future.
Besides that, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
In order to more evenly apply the projects PEP8 style guidelines, this PR applies
black
,isort
, andflake8
formatting to pre-commit hooks, and push/PR workflows.Most python files in the repository have been reformatted. Files auto-generated for
protos
are excluded.Documentation has been updated to reflect these changes.
To use pre-commit hooks (which will reformat and warn of needed changes, and prevent rejected pushes/PRs)
If pre-commit hooks fix a problem, the commit will need to be run again to complete successfully.
The style tools can be run manually:
mypy
has not been included in this PR due to the large number of changes neededyamlfix
has not been included in this PR, it was causing type conversion issues with the repoCloses #303
Describe testing procedures
Sample output
No changes.
Checklist