Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScanIso Timezone Removal #302

Merged
merged 2 commits into from
Jan 30, 2023
Merged

ScanIso Timezone Removal #302

merged 2 commits into from
Jan 30, 2023

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Jan 27, 2023

Describe the change
As ISO files do not store timezone data, including a Zulu time (Z) in times is not completely accurate and may lead to incorrect assumptions about file times.

  • Removing Zulu reference from times from ScanIso
  • Updating ScanIso tests to reflect change
  • Formatting ScanIso with black

Describe testing procedures
Executed pytest -s src/python/strelka/tests/test_scan_iso.py

(virtualenv) desktop:strelka test$ pytest -s src/python/strelka/tests/test_scan_iso.py 
==================================================================================================================================== test session starts =====================================================================================================================================
platform darwin -- Python 3.10.9, pytest-7.2.0, pluggy-1.0.0
rootdir: /Users/test/Desktop/GitHub/strelka/src/python
plugins: unordered-0.5.2, mock-3.10.0
collected 1 item                                                                                                                                                                                                                                                                             

src/python/strelka/tests/test_scan_iso.py .

===================================================================================================================================== 1 passed in 0.66s ======================================================================================================================================

Sample output

...
            "meta": {
                "date_created": "2022-12-11T18:42:00",
                "date_effective": None,
                "date_expiration": None,
                "date_modification": "2022-12-11T18:42:00",
                "volume_identifier": "NEW_VOLUME                      ",
            },
...

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer requested a review from ryanohoro January 27, 2023 14:55
@ryanohoro
Copy link
Collaborator

LGTM

@phutelmyer phutelmyer merged commit c6a5c26 into master Jan 30, 2023
@phutelmyer phutelmyer deleted the scan-iso-timezone branch January 30, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants