Limiter for Javascript Output, Tests, Formatting #301
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
With no limits set for the
string
fields (e.g.,tokens
,strings
) inScanJavascript
, events have been observed with well over thousands of objects in their associated fields. While this may be useful for some use cases, by default it may be advisable to not collect so many objects. The following modification were implemented:50
) for amount of strings per field to be collected fromScanJavascript
session. Configurable inbackend.yml
The following fields are limited:
Describe testing procedures
Created test:
test_scan_javascript_character_limits
intest_scan_javascript.py
that ensures that the limit functions properly.Sample output
Checklist