Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixtures/test.xml and test_scan_xml.py #267

Merged
merged 2 commits into from
Dec 29, 2022

Conversation

RondoRondoRondo
Copy link

Describe the change
Created a test for the xml scanner, 'test_scan_xml.py', with a corresponding test file, 'test.xml'.

Describe testing procedures
Difference test on the expected output of the xml scanner and the output of the test.xml file.
docker-compose -f ./build/docker-compose.yaml build backend

Sample output
No change to Strelka's output.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer
Copy link
Contributor

Thanks for the PR, @RondoRondoRondo!
I removed the print statement, but looks good + merged.

@phutelmyer phutelmyer merged commit 695503e into target:master Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants