Increasing strictness for LNK taste #246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
This change, proposed by @ryanohoro, was identified as ScanLnk was identified matching and running against files that, while matched the YARA rule, were not proper LNK files. This change updates the YARA taste to reduce false positives for ScanLnk execution.
Additional bug identified when scanning LNK files, requiring an update to the
construct
package.Describe testing procedures
Tested against several LNK files as well as previously identified false positives.
Sample output
N/A
Checklist