Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing strictness for LNK taste #246

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Increasing strictness for LNK taste #246

merged 3 commits into from
Dec 20, 2022

Conversation

phutelmyer
Copy link
Contributor

@phutelmyer phutelmyer commented Dec 16, 2022

Describe the change
This change, proposed by @ryanohoro, was identified as ScanLnk was identified matching and running against files that, while matched the YARA rule, were not proper LNK files. This change updates the YARA taste to reduce false positives for ScanLnk execution.

Additional bug identified when scanning LNK files, requiring an update to the construct package.

Describe testing procedures
Tested against several LNK files as well as previously identified false positives.

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer merged commit 4b8362f into master Dec 20, 2022
@phutelmyer phutelmyer deleted the lnk-taste-fix branch December 30, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant