Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ScanQR Debug Logging #201

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

phutelmyer
Copy link
Contributor

Describe the change
Updated ScanQR logging to remove [DEBUG] statements from outputting on invalid strings.

Before:

strelka_backend_1      | 2022-04-26 12:00:59 - [DEBUG] PIL.PngImagePlugin [PngImagePlugin.call]: STREAM b'pHYs' 41 9
strelka_backend_1      | 2022-04-26 12:00:59 - [DEBUG] PIL.PngImagePlugin [PngImagePlugin.call]: STREAM b'IDAT' 62 2975
strelka_backend_1      | 2022-04-26 12:00:59 - [DEBUG] PIL.PngImagePlugin [PngImagePlugin.call]: STREAM b'IHDR' 16 13
strelka_backend_1      | 2022-04-26 12:00:59 - [DEBUG] PIL.PngImagePlugin [PngImagePlugin.call]: STREAM b'pHYs' 41 9
strelka_backend_1      | 2022-04-26 12:00:59 - [DEBUG] PIL.PngImagePlugin [PngImagePlugin.call]: STREAM b'IDAT' 62 20871

After:
No [DEBUG] statements expected

Describe testing procedures
Built PR and tested against various files that reported [DEBUG] statements.

Sample output
N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer added bug Something isn't working enhancement New feature or request labels Apr 26, 2022
@phutelmyer phutelmyer self-assigned this Apr 26, 2022
@phutelmyer phutelmyer merged commit 5192d29 into master Apr 26, 2022
@phutelmyer phutelmyer deleted the 2022-04-26-ScanQR_Logging_Update branch May 2, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant