Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Archive library for ExifTools #197

Merged

Conversation

cameron-dunn-sublime
Copy link
Contributor

@cameron-dunn-sublime cameron-dunn-sublime commented Feb 10, 2022

Describe the change

ExifTools requires a perl library "Archive" to successfully inspect some word documents ([1]). This PR installs the required library in the Docker build.

This thread pretty much describes the symptom and how to fix it: https://exiftool.org/forum/index.php?topic=5087.0

  1. Some quick testing suggests docx and docm files require the extension, but it's probably more complex than that. I have a doc file which has the same output before/after the chance, and doesn't include any zip fields.

Describe testing procedures

I tested this by just doing docker run on before/after images and then running exiftool within.

Results w/o Archive library
Result w/ Archive library

Test file (a super simple doc)

Sample output
No direct modification -- some files already looked pretty much identical. Effected file types will have different attributes returned for ScanExifToo.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer merged commit 7539a6e into target:master Mar 2, 2022
@phutelmyer
Copy link
Contributor

Apologies for the delay here, @cameron-dunn-sublime. I've reviewed and tested this change. Looks good to me.
Thanks for the PR!

@cameron-dunn-sublime cameron-dunn-sublime deleted the cd.exiftool-archive-library branch April 10, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants