New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving Dockerfiles for Rebuilds #171

Merged

phutelmyer merged 2 commits into target:master from Derekt2:master

Jun 2, 2021

Contributor

Derekt2 commented Jun 1, 2021

Describe the change

Reduces time to REBUILD from ~8 minutes to ~11 seconds upon creating new or modifying scanner.
Follow's Dockerfile best practices by layer caching dependencies.
Should make new scanner development more efficient for editing, testing, modifying.

Describe testing procedures

Forked the repo, testing building with and without changes, still builds OK and is drastically faster on REBUILDS.

Sample output

No changes to final built images

Checklist

[ * ] My code follows the style guidelines of this project
[ * ] I have performed a self-review of and tested my code
[ * ] I have commented my code, particularly in hard-to-understand areas
[ * ] I have made corresponding changes to the documentation
[ * ] My changes generate no new warnings

Derekt2 added 2 commits

June 1, 2021 08:45


          improving dockerfiles

108e01d


          adding comment

da27f01

Contributor

phutelmyer commented Jun 2, 2021 •

edited

Loading

Tested, modified, and tested again.

Original test build: 7 minutes, 22 seconds
Rebuild: 10 seconds

Everything works great.

Thanks @Derekt2 ! Great use of caching.

phutelmyer merged commit 3709409 into target:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet