Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to move files to processed directory after submission #154

Merged
merged 4 commits into from
Feb 26, 2021

Conversation

weslambert
Copy link
Contributor

Describe the change
Allows files to be moved to another directory (out of staging) after being submitted for scanning. This directory can be specified by adding files.processed to filestream.yaml.

Describe testing procedures
Tested with:

  • /nsm/strelka/unprocessed as files.patterns
  • /nsm/strelka/staging as staging
  • /nsm/strelka/processed as files.processed
  1. echo "MyTestFileContent" > /nsm/strelka/unprocessed/mytestfile
  2. File is moved by Strelka into /nsm/strelka/staging.
  3. File is submitted for scanning, then moved to /nsm/strelka/processed.

Shout-out to @rwwiv for his help with this, bc I can't Golang good 😆 .

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer phutelmyer added the enhancement New feature or request label Feb 25, 2021
@phutelmyer phutelmyer self-assigned this Feb 25, 2021
@phutelmyer
Copy link
Contributor

Gave this a few tests, and it looks good to me.
Thanks @weslambert and @rwwiv!

@phutelmyer phutelmyer merged commit caa55db into target:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants