Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Disable Strelka Backend Shutdown #145

Merged
merged 4 commits into from
Dec 2, 2020
Merged

Add Option to Disable Strelka Backend Shutdown #145

merged 4 commits into from
Dec 2, 2020

Conversation

weslambert
Copy link
Contributor

Describe the change
This change provides the option to prevent strelka-backend from shutting itself down after max_files or time_to_live has been reached.

Describe testing procedures
Rebuilt the strelka-backend image and tested using a value of 0 for max_files and time_to_live in backend.yml

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of and tested my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@phutelmyer
Copy link
Contributor

Tested configurations with 0 max_files and 0 time_to_live successfully. I advise caution as those limits (specifically time) were implemented to reduce the potential memory issues. However, this implementation works and I appreciate you putting the time in.

@phutelmyer phutelmyer merged commit 8872667 into target:master Dec 2, 2020
@phutelmyer phutelmyer added the enhancement New feature or request label Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants