-
Notifications
You must be signed in to change notification settings - Fork 69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs! I have a few comments, if you want I can apply the suggestions.
trailing `./.` will not be watched by `lorri`) | ||
3. when using a construct like `import ./.` to import a `default.nix` | ||
file, `lorri` watches the current directory recursively. To get | ||
around it, use `import ./default.nix`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that true? Normally import ./.
is an alias for ./default.nix
, so I’m suprised this happens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I'll need to explore this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to post my findings, but yes this is true! Nix doesn't emit /path/to/default.nix
as the true file, it emits just '/path/to. A possible solution here is to append a
/default.nix` when an imported directory is identified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, opened a separate issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is now fixed: https://github.com/target/lorri/blob/master/src/builder.rs#L160-L170
See #249
Sorry @Profpatsch I missed this message. I am watching the repo and did not see it in all the recent updates. All your comments made sense. Regarding your question about the remark in parens. I was noting that despite the fact that we use the string |
No description provided.