Skip to content
This repository has been archived by the owner on Oct 15, 2022. It is now read-only.

Document unexpected reevaluations #21

Merged
merged 1 commit into from
Apr 10, 2019
Merged

Conversation

dudebout
Copy link
Contributor

@dudebout dudebout commented Apr 1, 2019

No description provided.

Copy link
Collaborator

@Profpatsch Profpatsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs! I have a few comments, if you want I can apply the suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
trailing `./.` will not be watched by `lorri`)
3. when using a construct like `import ./.` to import a `default.nix`
file, `lorri` watches the current directory recursively. To get
around it, use `import ./default.nix`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that true? Normally import ./. is an alias for ./default.nix, so I’m suprised this happens.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I'll need to explore this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to post my findings, but yes this is true! Nix doesn't emit /path/to/default.nix as the true file, it emits just '/path/to. A possible solution here is to append a /default.nix` when an imported directory is identified.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, opened a separate issue.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dudebout
Copy link
Contributor Author

Thanks for the docs! I have a few comments, if you want I can apply the suggestions.

Sorry @Profpatsch I missed this message. I am watching the repo and did not see it in all the recent updates. All your comments made sense. Regarding your question about the remark in parens. I was noting that despite the fact that we use the string ./. we did not hit the issue where lorri watches the full directory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants