This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in #133 is pretty good, check out these proposed patches for some feedback / suggestions
This borrows upstream Rust code to implement a Lines iterator which produces OsStrings, and replaces the parse_nix_output code to use it. From the commit where I drop that function:
Finally, in the tests for the builder I add a proof-positive test to assert that the bytes come through and that the shell derivation is produced.