This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
Builder: use OutputPaths for root names #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
reviewed
Aug 15, 2019
grahamc
reviewed
Aug 15, 2019
Profpatsch
changed the base branch from
master
to
builder-restrict-named-drvs-to-struct
grahamc
force-pushed
the
builder-restrict-named-drvs-to-struct
branch
from
278c503 to
76f0e31
Compare
grahamc
force-pushed
the
builder-use-OutputPaths-for-root-names
branch
from
630502b to
27afeba
Compare
grahamc
changed the base branch from
builder-restrict-named-drvs-to-struct
to
master
Profpatsch
force-pushed
the
builder-use-OutputPaths-for-root-names
branch
from
27afeba to
c576b95
Compare
`roots` needs to be able to access private fields of project.
grahamc
force-pushed
the
builder-use-OutputPaths-for-root-names
branch
2 times, most recently
from
8f3b218 to
26543c5
Compare
grahamc
changed the title
grahamc
approved these changes
Aug 29, 2019
Use the `OutputPaths` struct to direct the creation of roots, so that we don’t have to rely on “magical paths” anymore. This is another step towards splitting instantiation and build.
grahamc
force-pushed
the
builder-use-OutputPaths-for-root-names
branch
from
26543c5 to
90aebe2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of #117 for easier review.
Contains #134