Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix slice init length #4090

Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix: fix slice init length #4090

merged 2 commits into from
Oct 7, 2024

Conversation

cuishuang
Copy link
Contributor

@cuishuang cuishuang commented Oct 4, 2024 •
edited by mastercactapus
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:

The intention here should be to initialize a slice with a capacity of len(alertIDs) rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

@mastercactapus mastercactapus merged commit 29da739 into target:master Oct 7, 2024
7 checks passed
@cuishuang cuishuang mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastercactapus mastercactapus mastercactapus approved these changes

@KatieMSB KatieMSB KatieMSB approved these changes

Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuishuang @mastercactapus @KatieMSB