Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update draggable list ux #3207

Merged
merged 13 commits into from
Aug 16, 2023
Merged

ui: update draggable list ux #3207

merged 13 commits into from
Aug 16, 2023

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Aug 3, 2023

Description:

  • Updates flatlist drag and drop UX
  • Updates Escalation Policy Steps List to use FlatList

Which issue(s) this PR fixes:
For significant amounts of work, it is best to start an issue first, preferably before the work is started.
For large pull requests, be sure to reference the associated GitHub issue(s).

Usage: Fixes #<issue number>, or Fixes (paste link of issue).

Out of Scope:

  • The caching update logic for steps flickers for a moment before "sticking"

Screenshots:

rotation

ep

allending313
allending313 previously approved these changes Aug 10, 2023
Copy link
Collaborator

@allending313 allending313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@allending313 allending313 dismissed their stale review August 10, 2023 18:37

cypress test failing

@mastercactapus
Copy link
Member

A couple quick questions:

  • Is the flicker a regression introduced in this change or an existing bug?
  • Are these still keyboard accessible?

@Forfold
Copy link
Contributor Author

Forfold commented Aug 11, 2023

@mastercactapus The flicker is introduced for Escalation Policies as it is using the same caching logic but a new drag and drop library. It is probably for the best to address that as a follow-up ticket.

They are both still keyboard accessible (this is what the tests cover).

@Forfold
Copy link
Contributor Author

Forfold commented Aug 16, 2023

@mastercactapus I copied over the logic from rotation's optimistic update and it didn't flicker 🎉 so, thanks for calling it out 😄 It should be fixed now.

Copy link
Contributor

@andrewbenington andrewbenington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works smoothly for me!

@Forfold Forfold merged commit 153d01a into master Aug 16, 2023
6 checks passed
@Forfold Forfold deleted the draggable-list branch August 16, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants