-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: update draggable list ux #3207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A couple quick questions:
|
@mastercactapus The flicker is introduced for Escalation Policies as it is using the same caching logic but a new drag and drop library. It is probably for the best to address that as a follow-up ticket. They are both still keyboard accessible (this is what the tests cover). |
@mastercactapus I copied over the logic from rotation's optimistic update and it didn't flicker 🎉 so, thanks for calling it out 😄 It should be fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works smoothly for me!
Description:
Which issue(s) this PR fixes:
For significant amounts of work, it is best to start an issue first, preferably before the work is started.
For large pull requests, be sure to reference the associated GitHub issue(s).
Usage:
Fixes #<issue number>
, orFixes (paste link of issue)
.Out of Scope:
Screenshots: