alert details: show sent notification delivery delays in alert log #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Marquis <[email protected]>
Co-authored-by: Chris Marquis <[email protected]> Co-authored-by: Allen Ding <[email protected]>
…feat-delivery-delay
mastercactapus
changed the title
mastercactapus
previously approved these changes
Jul 19, 2023
mastercactapus
previously approved these changes
Jul 24, 2023
cmarquis
dismissed stale reviews from allending313 and mastercactapus
via
a4d02f5
allending313
approved these changes
Jul 27, 2023
mastercactapus
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Adds additional information to the alert log when a message was delivered after two minutes of being queued. This is useful for troubleshooting if a user reports an alert took longer than expected to be delivered.
Which issue(s) this PR fixes:
Fixes #2699
Screenshots:
Describe any introduced user-facing changes:
The alert log will show how many hours and minutes it took to deliver a notification, if it took more than 2 minutes.
Describe any introduced API changes:
None
Additional Info:
None