Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add option to set noise reasons for an alert #3133

Merged
merged 36 commits into from
Jul 12, 2023
Merged

add option to set noise reasons for an alert #3133

merged 36 commits into from
Jul 12, 2023

Conversation

Forfold
Copy link
Contributor

@Forfold Forfold commented Jun 28, 2023 •
edited
Loading

Description:

  • Adds the ability to set notes on an alert to document signal to noise.
  • When set, a notice will appear at the top of the alert with the option to undo.
  • Moves the alert update buttons to the left (Ack, Escalate, Close), making them primary contained text buttons instead of secondary icon buttons.

Which issue(s) this PR fixes:

Out of Scope:

  • Updating alert metrics table & graph to include section for alerts with notes set

Screenshots:

New alert, no action taken

Screenshot 2023-06-28 at 11 03 57 AM

New alert, some notes checked

Screenshot 2023-06-28 at 11 04 34 AM

Notes set on alert, notice shown

Screenshot 2023-06-28 at 11 04 42 AM

Describe any introduced API changes:

  • Added type feedback to alert with the field note

@Forfold
add ability to store alert metadata from ui
8d686a5
@Forfold
simplify bool
4642f60
@Forfold
update metadata to feedback
be50341
@Forfold
update transition for textfields
4649165
@Forfold
fix console warning
b1a2c24
@Forfold
invalidate cache on feedback button press
7ce3c3c
@Forfold
add testing and aria labels
1c23810
@Forfold
metadata -> feedback
e8c89f0
@Forfold
remove comment
80b629c
@Forfold
remove sentiment field
e369f36
@Forfold
use dialog to set alert feedback
c952838
@Forfold
add notice to show problem alert reason with undo
e63ed43
@Forfold
styling updates
0706219
@Forfold
start using checkboxes to set reasons
046bb20
@Forfold
fix checkbox bugs when setting
8f93570
@Forfold
set defaults when editing
cee16f2
@Forfold
always show feedback options instead of in dialog
647cbdd
@Forfold
use submit, hide card when banner showing
129761b
@Forfold
remove unused imports
4c2f896
@Forfold
Grammar/wording
a23f11c
@Forfold
add transition and disable submit when empty
ac6cd57
@Forfold
add testing
c611bdd
@Forfold
remove .only from test
50ec5ca
@Forfold
revert exporting transitions
8bcd087
@Forfold
Merge branch 'master' into alert-feedback
aae1191
mastercactapus
mastercactapus requested changes Jun 29, 2023
View reviewed changes
migrate/migrations/20230616110941-add-alerts-feedback.sql Outdated Show resolved Hide resolved
graphql2/schema.graphql Outdated Show resolved Hide resolved
alert/store.go Outdated Show resolved Hide resolved
andrewbenington
andrewbenington previously approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@andrewbenington andrewbenington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, plus the sql files are more readable now

mastercactapus
mastercactapus requested changes Jul 6, 2023
View reviewed changes
alert/store.go Outdated Show resolved Hide resolved
alert/store.go Outdated Show resolved Hide resolved
alert/store.go Outdated Show resolved Hide resolved
alert/store.go Show resolved Hide resolved
graphql2/graphqlapp/alert.go Outdated Show resolved Hide resolved
graphql2/graphqlapp/alert.go Show resolved Hide resolved
mastercactapus
mastercactapus reviewed Jul 6, 2023
View reviewed changes
alert/store.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added size/xl and removed size/l labels Jul 6, 2023
@Forfold Forfold changed the title add option to set notes on an alert add option to set noise reasons for an alert Jul 11, 2023
andrewbenington
andrewbenington previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@andrewbenington andrewbenington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

mastercactapus
mastercactapus requested changes Jul 11, 2023
View reviewed changes
alert/store.go Show resolved Hide resolved
migrate/migrations/20230616110941-add-alerts-feedback.sql Outdated Show resolved Hide resolved
@mastercactapus mastercactapus merged commit 34dcd40 into master Jul 12, 2023
4 checks passed
@mastercactapus mastercactapus deleted the alert-feedback branch July 12, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mastercactapus mastercactapus mastercactapus approved these changes

@andrewbenington andrewbenington andrewbenington approved these changes

@tony-tvu tony-tvu Awaiting requested review from tony-tvu

Assignees
No one assigned
Labels
size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to Record Alert Usefulness (noise)
4 participants
@Forfold @mastercactapus @andrewbenington @tony-tvu