Models and Traits Publishable #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laravel 11
- ### Braking Change: Made the Models and Traits Publishable, so you can add SoftDeletes, auditing, and/or caching if you want (YOU MUST RUN THE INSTALLATION COMMAND) - ### Braking Change: Check your Namespaces - Moved the config functions to a Trait so adding functions is as simple as editing the published Trait or adding another Trait - I left the original `LaravelConfig` class as an alies of the Model, but it needs more testing - ### Braking Change: The Update function needed to be renamed from `update` to `update_config` - ### Braking Change: The Update function Only takes one parameter just the `ConfigItem` - ### Braking Change: The `update_config` helper Only takes one parameter just the `ConfigItem` - ### Braking Change: The Delete function needed to be renamed from `delete` to `delete_config` - Because of the Braking Changes I also added a `get_config`, `set_config`, `has_config`, and `create_config` aliases for consistency - NON Braking Change: Removed the `all` function as it's not needed anymore since it's a function of a Model - I'm adding more functions to another Trait that can be added by including it in the Model these are all traits that I've found useful
|
this is also a simpler alternative to #35 because if the Models are published anyone can change the caster by just changing the class that it uses |
Apply fixes from StyleCI
Update ConfigDataType.php
Apply fixes from StyleCI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Braking Change: Made the Models and Traits Publishable, so you can add SoftDeletes, auditing, and/or caching if you want (YOU MUST RUN THE INSTALLATION COMMAND)
Braking Change: Check your Namespaces
LaravelConfigclass as an alies of the Model, but it needs more testingBraking Change: The Update function needed to be renamed from
updatetoupdate_configBraking Change: The Update function Only takes one parameter just the
ConfigItemBraking Change: The
update_confighelper Only takes one parameter just theConfigItemBraking Change: The Delete function needed to be renamed from
deletetodelete_configget_config,set_config,has_config, andcreate_configaliases for consistencyallfunction as it's not needed anymore since it's a function of a ModelThis fixes #38 and #37