Wb 624 event machine convert context validation methods to static in invokable behavior class #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omplete context Add a new test case to ensure that hasMissingContext returns null when all required context is present.
Add new tests to ensure hasMissingContext checks for type constraints. Previously, the tests did not validate data types for required context.
…sage Add a test to ensure validateRequiredContext throws an exception with the correct missing key message.
Add test ensuring validateRequiredContext passes when context is complete
…static Update `requiredContext`, `hasMissingContext`, and `validateRequiredContext` methods to be static for consistency and easier usage. Adjust context property and method calls accordingly.
…ction classes Make $requiredContext static in IsOddGuard, IsValidatedOddGuard, and IsOddAction for consistent usage across these classes.
Simplify test cases by calling static methods directly from TestBehavior classes instead of creating instance objects.
tkaratug
approved these changes
Nov 6, 2024
aydinfatih
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make InvokableBehavior context validation methods static
Background
The
InvokableBehaviorclass provides context validation functionality throughhasMissingContext()andvalidateRequiredContext()methods. These methods were instance-based but did not rely on any instance state since they only validate required context types against provided context values.Changes
$requiredContextproperty static inInvokableBehaviorclass and its subclasseshasMissingContext()andvalidateRequiredContext()to static methods$requiredContextWhy
$requiredContextin each behavior class) rather than instance-based, static methods make more senseBackwards Compatibility
This is a breaking change as it modifies method signatures and property visibility. Any code that relies on instance-based context validation will need to be updated to use static calls.