Able to Reset All Fakes #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that fake instances are properly cleaned up by adding missing offsetUnset call.
Provide method to reset all fakes in application container. This ensures that fakes can be cleared consistently, avoiding potential conflicts in subsequent tests.
Rename MachineFacade to EventMachine for clearer representation and consistency. Updated composer.json to reflect the new alias.
This change adds a new EventMachine class with a method to reset all fake invocations to their default state using the InvokableBehavior utility.
Add a new test to verify that all fakes can be reset simultaneously. This ensures that the EventMachine facade's resetAllFakes method behaves as expected.
…instances in container
…ake reset Add a test to ensure that the Mockery container is cleaned when all fakes are reset in InvokableBehaviorFakeTest.php.
…ion after reset Add a new test to ensure behavior isolation is maintained after resetting all fakes. This test verifies that TestIncrementAction and TestCountGuard fakes operate independently following a reset.
…s with trait instances Add new test to ensure resetting fakes with different trait instances works consistently. Enhances coverage for behavior isolation.
tkaratug
approved these changes
Nov 6, 2024
aydinfatih
requested changes
Nov 6, 2024
Introduce cleanupLaravelContainer method to remove fake instances from Laravel's container, preventing memory leaks and ensuring proper state reset between tests.
This new method cleans up Mockery expectations for a given mock instance.
Previously, the resetFakes method did not comprehensively clean up Laravel container and Mockery expectations, leading to potential leaks or unexpected behavior. This change introduces thorough cleanup to ensure that both the Laravel container and Mockery expectations are accurately reset.
Reset process now uses dedicated cleanup functions for improved clarity and maintainability.
aydinfatih
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resetAllFakes method within the Fakeable trait is intended to clear all fake instances from the application container. However, it appears to be leaving some bindings intact, leading to failures in tests expecting the container to be fully reset. This behavior is likely due to the incomplete handling of bindings and instances in the reset process, impacting App::bind, App::has, and App::forgetInstance.