Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing signage on release binaries #132

Open
jberumen3 opened this issue Nov 28, 2023 · 1 comment · May be fixed by #242
Open

Missing signage on release binaries #132

jberumen3 opened this issue Nov 28, 2023 · 1 comment · May be fixed by #242
Labels
enhancement New feature or request

Comments

@jberumen3
Copy link

As of 2023-11-27, the release binaries are not signed.

Please offer signage of binaries.
@tareqimbasher
Copy link
Owner

Planned for the near future.

@tareqimbasher tareqimbasher added the enhancement New feature or request label Dec 27, 2023
hootanht added a commit to hootanht/NetPad that referenced this issue Aug 10, 2024
@hootanht
Add signing to release binaries
429f2a5 
Fixes tareqimbasher#132

Add code signing to release binaries

* **scripts/package-electron.sh**
  - Add a check for `osslsigncode` command.
  - Add steps to sign `.exe` files using `osslsigncode` with environment variables for certificate path and password.

* **src/Apps/NetPad.Apps.App/electron.manifest.js**
  - Add signing options for Windows binaries using `osslsigncode` with environment variables for certificate path and password.

* **.github/workflows/build.yml**
  - Add a step to sign Windows binaries using `osslsigncode` with secrets for certificate path and password.
@hootanht hootanht linked a pull request Aug 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add signing to release binaries hootanht/NetPad
2 participants
@tareqimbasher @jberumen3