fix(ci): remove dependency on pprof to fix windows ci

Signed-off-by: Tarek <[email protected]>
tareknaser · Apr 27, 2024 · d241628 · d241628
1 parent 61c3ab9
commit d241628
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -51,7 +51,7 @@ jobs:
       - name: Install Rust
         uses: dtolnay/rust-toolchain@stable
       - name: Install pdfium
-        run: brew install pdfium
+        run: .github/scripts/pdfium.sh
       - name: Run tests
         run: cargo test --verbose
 

diff --git a/data-resource/Cargo.toml b/data-resource/Cargo.toml
@@ -21,7 +21,6 @@ anyhow = "1"
 [dev-dependencies]
 # benchmarking
 criterion = { version = "0.5", features = ["html_reports"] }
-pprof = { version = "0.13", features = ["criterion", "flamegraph"] }
 rand = "0.8"
 
 [[bench]]

diff --git a/data-resource/benches/compute_bytes_benchmark.rs b/data-resource/benches/compute_bytes_benchmark.rs
@@ -1,6 +1,5 @@
 use criterion::{black_box, criterion_group, criterion_main, Criterion};
 use data_resource::ResourceId;
-use pprof::criterion::{Output, PProfProfiler};
 use rand::prelude::*;
 use std::fs;
 
@@ -66,7 +65,7 @@ fn compute_bytes_on_files_benchmark(c: &mut Criterion) {
 
 criterion_group!(
     name = benches;
-    config = Criterion::default().with_profiler(PProfProfiler::new(100, Output::Flamegraph(None)));
+    config = Criterion::default();
     targets = compute_bytes_on_raw_data, compute_bytes_on_files_benchmark
 );
 criterion_main!(benches);
diff --git a/fs-index/Cargo.toml b/fs-index/Cargo.toml
@@ -28,7 +28,6 @@ tempdir = "0.3.7"
 rstest = '0.18.2'
 # benchmarking
 criterion = { version = "0.5", features = ["html_reports"] }
-pprof = { version = "0.13", features = ["criterion", "flamegraph"] }
 rand = "0.8"
 
 [[bench]]

diff --git a/fs-index/benches/index_build_benchmark.rs b/fs-index/benches/index_build_benchmark.rs
@@ -2,7 +2,6 @@ use criterion::{
     black_box, criterion_group, criterion_main, BenchmarkId, Criterion,
 };
 use fs_index::index::ResourceIndex;
-use pprof::criterion::{Output, PProfProfiler};
 
 const DIR_PATH: &str = "../test-assets/"; // Set the path to the directory containing the resources here
 
@@ -36,7 +35,7 @@ fn index_build_benchmark(c: &mut Criterion) {
 
 criterion_group! {
     name = benches;
-    config = Criterion::default().with_profiler(PProfProfiler::new(100, Output::Flamegraph(None)));
+    config = Criterion::default();
     targets = index_build_benchmark
 }
 criterion_main!(benches);