fix(ci): disable benchmarks for all crates in the workspace

The bench feature has been disabled for all crates within the workspace to resolve an issue encountered during CI testing. The reason is that by default, Cargo implicitly adds a libtest benchmark harness to any crate when benchmarking, to handle any #[bench] functions, even if we have none. This ruins our Benchmarking CI with the error (Unrecognized option: save-baseline) in the logs. For more details: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options Signed-off-by: Tarek <[email protected]>
tareknaser · Mar 14, 2024 · 594d837 · 594d837
1 parent ba41bd8
commit 594d837
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 0 deletions.
diff --git a/data-error/Cargo.toml b/data-error/Cargo.toml
@@ -3,6 +3,11 @@ name = "data-error"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "data_error"
+crate-type = ["rlib"]
+bench = false
+
 [dependencies]
 thiserror = "1"
 reqwest = "0.11.11"

diff --git a/data-json/Cargo.toml b/data-json/Cargo.toml
@@ -3,6 +3,10 @@ name = "data-json"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "data_json"
+crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 serde_json = "1.0.82"

diff --git a/data-link/Cargo.toml b/data-link/Cargo.toml
@@ -6,6 +6,7 @@ edition = "2021"
 [lib]
 name = "data_link"
 crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 fs-atomic-light = { path = "../fs-atomic-light" }

diff --git a/data-pdf/Cargo.toml b/data-pdf/Cargo.toml
@@ -6,6 +6,7 @@ edition = "2021"
 [lib]
 name = "data_pdf"
 crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 once_cell = "1.16.0"

diff --git a/fs-atomic-light/Cargo.toml b/fs-atomic-light/Cargo.toml
@@ -6,6 +6,7 @@ edition = "2021"
 [lib]
 name = "fs_atomic_light"
 crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 data-error = { path = "../data-error" }
diff --git a/fs-atomic-versions/Cargo.toml b/fs-atomic-versions/Cargo.toml
@@ -6,6 +6,7 @@ edition = "2021"
 [lib]
 name = "fs_atomic_versions"
 crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 data-error = { path = "../data-error" }

diff --git a/fs-metadata/Cargo.toml b/fs-metadata/Cargo.toml
@@ -3,6 +3,10 @@ name = "fs-metadata"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "fs_metadata"
+crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 data-error = { path = "../data-error" }

diff --git a/fs-properties/Cargo.toml b/fs-properties/Cargo.toml
@@ -3,6 +3,10 @@ name = "fs-properties"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "fs_properties"
+crate-type = ["rlib"]
+bench = false
 
 [dependencies]
 data-error = { path = "../data-error" }

diff --git a/fs-storage/Cargo.toml b/fs-storage/Cargo.toml
@@ -3,5 +3,9 @@ name = "fs-storage"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+name = "fs_storage"
+crate-type = ["rlib"]
+bench = false
 
 [dependencies]