Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coveralls #94

Merged
merged 14 commits into from
Mar 12, 2014
Merged

Fix coveralls #94

merged 14 commits into from
Mar 12, 2014

Conversation

wkerzendorf
Copy link
Member

Fix the problems with coveralls. This should now work as expected

Added testing for three setups described in the .travis.yml file. This includes the new coverage.

@wkerzendorf
Copy link
Member Author

@mdboom This is a semi-affiliated package of astropy (using the setup stuff of astropy). I implemented the changes to get coverage working. It now produces a .coverage file (https://www.dropbox.com/s/3c6ng6r25j9bvq9/coverage). When I look at the coverage file it only shows me lines in astropy that are covered - not in the TARDIS package (despite there being tests). Would it be possible for you to have a quick look? Thanks in advance

@mdboom
Copy link

mdboom commented Mar 11, 2014

pip install astropy doesn't install the recent changes to astropy master that are needed to make this work. You can have pip install astropy from git in your .travis.yml or wait for the next astropy release.

@wkerzendorf
Copy link
Member Author

@mdboom Thank you. I hadn't thought about this.

@wkerzendorf
Copy link
Member Author

@ssim @mklauser toughts? I'm ready to merge as soon as TRAVIS passes

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0819976 on wkerzendorf:general/fix_coveralls into fe6723a on tardis-sn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0f02a21 on wkerzendorf:general/fix_coveralls into fe6723a on tardis-sn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 6b27262 on wkerzendorf:general/fix_coveralls into fe6723a on tardis-sn:master.

@ssim
Copy link
Contributor

ssim commented Mar 12, 2014

Seems wise to me.

ssim added a commit that referenced this pull request Mar 12, 2014
@ssim ssim merged commit e7fa1d5 into tardis-sn:master Mar 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants