-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 version of TARDIS #879
Conversation
fix the conftest to use the right .so file rewrite the continuum_compare
Fix continuum_compare_data to be compatible with python3
Codecov Report
@@ Coverage Diff @@
## master #879 +/- ##
=========================================
Coverage ? 65.77%
=========================================
Files ? 83
Lines ? 5922
Branches ? 0
=========================================
Hits ? 3895
Misses ? 2027
Partials ? 0
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job - Py3 here we go!?
This PR enables the use of Python 3 for TARDIS. It also upgrades the versions of several of the underlying packets. The way to create a usable env for this version is to use the
tardis_env3.yml
file.We have also had several other smaller changes. Most notably there is now a
tardis.constants
module that imports all the constants from astropy. This PR currently still uses the constants version of astropy13 (using the mechanics in astropy31).This PR also has the side-effect that several known installation and testing problems disappeared.
All tests currently pass and the spectra look the same within the noise.
There are still a few documentation changes to make.
@chvogl @ssim I need one or both of you to sign-off on this PR.
(@yeganer your dream has finally come true)