Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 version of TARDIS #879

Merged
merged 32 commits into from
Feb 25, 2019
Merged

Python3 version of TARDIS #879

merged 32 commits into from
Feb 25, 2019

Conversation

wkerzendorf
Copy link
Member

@wkerzendorf wkerzendorf commented Feb 4, 2019

This PR enables the use of Python 3 for TARDIS. It also upgrades the versions of several of the underlying packets. The way to create a usable env for this version is to use the tardis_env3.yml file.

We have also had several other smaller changes. Most notably there is now a tardis.constants module that imports all the constants from astropy. This PR currently still uses the constants version of astropy13 (using the mechanics in astropy31).
This PR also has the side-effect that several known installation and testing problems disappeared.

All tests currently pass and the spectra look the same within the noise.

There are still a few documentation changes to make.
@chvogl @ssim I need one or both of you to sign-off on this PR.

(@yeganer your dream has finally come true)

@codecov-io
Copy link

codecov-io commented Feb 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@89270c2). Click here to learn what that means.
The diff coverage is 77.31%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #879   +/-   ##
=========================================
  Coverage          ?   65.77%           
=========================================
  Files             ?       83           
  Lines             ?     5922           
  Branches          ?        0           
=========================================
  Hits              ?     3895           
  Misses            ?     2027           
  Partials          ?        0
Impacted Files Coverage Δ
tardis/montecarlo/setup_package.py 0% <0%> (ø)
tardis/plasma/setup_package.py 0% <0%> (ø)
tardis/analysis.py 0% <0%> (ø)
tardis/simulation/setup_package.py 0% <0%> (ø)
tardis/gui/datahandler.py 0% <0%> (ø)
tardis/plasma/base.py 60.26% <0%> (ø)
tardis/io/config_reader.py 81.9% <0%> (ø)
tardis/gui/widgets.py 0% <0%> (ø)
tardis/plasma/standard_plasmas.py 82.89% <0%> (ø)
tardis/plasma/properties/ion_population.py 90.69% <100%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89270c2...817f618. Read the comment docs.

Copy link
Contributor

@ssim ssim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job - Py3 here we go!?

@wkerzendorf wkerzendorf merged commit 04b4472 into tardis-sn:master Feb 25, 2019
@wkerzendorf wkerzendorf deleted the tardis3 branch February 25, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants