Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some small fixes related to the documentation and the building process (Fix #842) #873

Merged
merged 4 commits into from
Oct 12, 2018

Conversation

unoebauer
Copy link
Contributor

@unoebauer unoebauer commented Oct 10, 2018

This small PR addresses a number of small issues which came up when resolving #872 (should also fix #842)

  • add warning about need for Python 2.7
  • update link to tardis_example.yml file on the docu
  • add cython back into the env file

@unoebauer
Copy link
Contributor Author

@wkerzendorf - did I insert the correct cython version? Also, are there some other small changes which we could/should include in this PR?

@unoebauer
Copy link
Contributor Author

Ok, Travis obviously thinks that I have added the wrong cython version...

@wkerzendorf
Copy link
Member

@unoebauer you did insert the "correct" cython version but I'm it still crashes with that. I think we need to handle this in the travis setup with an uninstall of cython and then reinstall using the self-built option.

@unoebauer
Copy link
Contributor Author

ok, I'll give it a try

@codecov-io
Copy link

Codecov Report

Merging #873 into master will increase coverage by 1.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #873      +/-   ##
==========================================
+ Coverage   82.26%   83.72%   +1.46%     
==========================================
  Files          34       34              
  Lines        2870     2870              
==========================================
+ Hits         2361     2403      +42     
+ Misses        509      467      -42
Impacted Files Coverage Δ
tardis/plasma/base.py 88.07% <0%> (+27.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c63953...e0e7232. Read the comment docs.

@unoebauer
Copy link
Contributor Author

@unoebauer - done! Travis is happy now.

@wkerzendorf
Copy link
Member

wkerzendorf commented Oct 12, 2018

I almost fixed it. but then I saw that you did.

@wkerzendorf wkerzendorf merged commit 3d01a85 into tardis-sn:master Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with Cython - include working version back into env file
3 participants