Unify unittest hdfs #864
Merged
Unify unittest hdfs #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkerzendorf
approved these changes
Aug 23, 2018
| @@ -130,68 +137,61 @@ def config(self, request): | |||
| else: | |||
| config.plasma[prop] = value | |||
| hash_string = '_'.join((hash_string, str(value))) | |||
| hash_string = "plasma_unittest/" + hash_string | |||
| @@ -70,6 +70,13 @@ def idfn(fixture_value): | |||
| '{}:{}'.format(k, v) for k, v in fixture_value.items()])) | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope='module') | |||
unoebauer
force-pushed
the
unify_unittest_hdfs
branch
from
30137da
to
71733e3
Compare
Codecov Report
@@ Coverage Diff @@
## master #864 +/- ##
=======================================
Coverage 82.26% 82.26%
=======================================
Files 34 34
Lines 2870 2870
=======================================
Hits 2361 2361
Misses 509 509Continue to review full report at Codecov.
|
|
This one is ready to be merged, @wkerzendorf, @chvogl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the HDF5 files containing the reference data for the unit tests. Currently, the data are stored in
unit_test_data.h5plasma_reference/reference_data.h5With this PR all data will be migrated to
unit_test_data.h5.