Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing refdata #849

Merged
merged 4 commits into from
Jul 30, 2018
Merged

Missing refdata #849

merged 4 commits into from
Jul 30, 2018

Conversation

wkerzendorf
Copy link
Member

No description provided.

@wkerzendorf
Copy link
Member Author

@unoebauer @chvogl can you sign off?

unoebauer
unoebauer reviewed Jul 27, 2018
View reviewed changes
Copy link
Contributor

@unoebauer unoebauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You basically outsourced all atomic data fixtures into a separate file and raise an error if the file is not present, right? What exit code is returned? (I remember 2 during our last sprint...)

@wkerzendorf
Copy link
Member Author

yep - it crashed. you can see the commit above not passing.

@wkerzendorf wkerzendorf merged commit df2bdf1 into tardis-sn:master Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unoebauer unoebauer unoebauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkerzendorf @unoebauer