-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify convergence strategies #821
Conversation
* remove the addition of unused properties to t_rad, t_inner and w
@wkerzendorf - what do you think? I still have to check the different tests and probably need to update some reference data... |
@unoebauer In general, I agree - it means that we will break backward compatibility (which we have done in the past and which I'm in favor off). |
True - but one only has to change the type from |
Ready to be merged from my point of view. |
Currently, there is very little difference between the two supported convergence strategies,
damped
andspecific
. Also, as noted in issue #695, a number of properties of theconvergence_strategy
are unused. This PR tries to simply the convergence strategy handling bydamped
(the name describes the current strategy to update the plasma variables best)lock_t_inner_cycles
,t_inner_update_exponent