Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify convergence strategies #821

Merged
merged 12 commits into from
Jun 27, 2018

Conversation

unoebauer
Copy link
Contributor

Currently, there is very little difference between the two supported convergence strategies, damped and specific. Also, as noted in issue #695, a number of properties of the convergence_strategy are unused. This PR tries to simply the convergence strategy handling by

  • merging the two existing strategies into one, which will be called damped (the name describes the current strategy to update the plasma variables best)
  • introduce support for currently unused properties, in particular for lock_t_inner_cycles, t_inner_update_exponent
  • remove remaining unused properties
  • introduce new property that controls whether the simulation stops before the specified number of iterations if the plasma quantities converged or not

@unoebauer
Copy link
Contributor Author

@wkerzendorf - what do you think? I still have to check the different tests and probably need to update some reference data...

@wkerzendorf
Copy link
Member

@unoebauer In general, I agree - it means that we will break backward compatibility (which we have done in the past and which I'm in favor off).

@unoebauer
Copy link
Contributor Author

True - but one only has to change the type from specific to damped. All other options are still valid under the updated convergence strategy handling

@unoebauer
Copy link
Contributor Author

Ready to be merged from my point of view.

@wkerzendorf wkerzendorf merged commit ae09381 into tardis-sn:master Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants