Fix NLTE #778
Merged
Fix NLTE #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
yeganer
force-pushed
the
j_blues_dataframe_master
branch
from
4576e34
to
7d5bdaa
Compare
yeganer
changed the title
yeganer
force-pushed
the
j_blues_dataframe_master
branch
from
7d5bdaa
to
63ffbc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a collection of changes related to the NLTE part of tardis.
The overall aim of this PR is to make NLTE work again with the current master version of tardis.
Additionally this PR introduces some improvements, like changing the type of some variables in the plasma (j_blues and beta_sobolevs) as well as merging a config option.