-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Comparison values in Plasma Unit Tests with reference HDF file #774
Merged
Merged
Changes from 26 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
6778992
Add reference HDF file for plasma tests
vg3095 f005039
Add plasma test class
vg3095 83d6603
Move plasma_ref_path inside tests class
vg3095 f783cc8
Use tardis-refdata option in Plasma tests
vg3095 69dd3dd
Added some new tests for plasma
vg3095 fccbf1a
Delete old plasma test files
vg3095 4060d4e
Add generate-reference option for Plasma Tests
vg3095 38ebff8
Fix indentation inside TestNLTEPlasma
vg3095 9cd60b3
Use atomic_data_fname fixture in plasma tests
vg3095 6b548dc
Use git checkpoint of PR#2 for tardis-refdata
vg3095 34e0412
Use tardis_ref_path fixture in plasma tests
vg3095 79ff2fc
Parametrize plasma tests
vg3095 a5e3e1e
Combine list of properties in plasma tests
vg3095 4e49f52
Use plasma as a class level fixture in tests
vg3095 a5f3758
Use yield fixture for HDF file in plasma tests
vg3095 74d2eb6
Add some more plasma tests
vg3095 32f1efa
Fix to use chianti_he_db dataset for NLTE config
vg3095 ad965c8
Update plasma tests to use chianti_he_db dataset
vg3095 f914c81
Generate different plasma config using fixture
vg3095 cf59431
Add a base plasma config
vg3095 bf4c5d4
Remove unused fixture
vg3095 cde7889
Generate plasma tests using list of config options
vg3095 cd1a6df
Fix negative power error in HeliumNLTE
vg3095 8e52780
Test for recomb-nlte option in plasma
vg3095 3632663
Add plasma test for delta treatment
vg3095 b2b53ce
Use w_epsilon when radiative_rates_type is detailed in plasma tests
vg3095 d178387
Add warning that nlte_data can't be saved
vg3095 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -282,6 +282,8 @@ def get_properties(self): | |
data['atom_data_uuid'] = self.atomic_data.uuid1 | ||
if 'atomic_data' in data: | ||
data.pop('atomic_data') | ||
if 'nlte_data' in data: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you add a warning here that |
||
data.pop('nlte_data') | ||
return data | ||
|
||
def to_hdf(self, file_path, path='', name=None, collection=None): | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
tardis_config_version: v1.0 | ||
|
||
supernova: | ||
luminosity_requested: 2.8e9 solLum | ||
time_explosion: 13 day | ||
|
||
atom_data: kurucz_atom_pure_simple.h5 | ||
|
||
model: | ||
|
||
structure: | ||
type: specific | ||
|
||
velocity: | ||
start: 1.1e4 km/s | ||
stop: 2.0e4 km/s | ||
num: 20 | ||
|
||
density: | ||
type: branch85_w7 | ||
|
||
abundances: | ||
type: uniform | ||
He: 1 | ||
|
||
plasma: | ||
ionization: lte | ||
excitation: lte | ||
radiative_rates_type: dilute-blackbody | ||
line_interaction_type: macroatom | ||
|
||
montecarlo: | ||
seed: 23111963 | ||
no_of_packets : 1.0e+5 | ||
iterations: 10 | ||
last_no_of_packets: 1.0e+5 | ||
no_of_virtual_packets: 5 | ||
|
||
spectrum: | ||
start: 500 angstrom | ||
stop: 20000 angstrom | ||
num: 10000 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only temporary, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is temporary.