Merge 'generate_reference_path' and 'reference_path' in integration tests (bug #672) #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdexd
reviewed
Mar 13, 2017
| 'gen_ref_path': os.path.join(os.path.expandvars(os.path.expanduser( | ||
| integration_tests_config['generate_reference'])), tardis_githash[:7] | ||
| ), | ||
| 'reference_filepath': ref_path, |
There was a problem hiding this comment.
You might want to think of another name here, because when you generate references, it would be like:
path/as/mentioned/in/yml/githash which is not "filepath" per se.
There was a problem hiding this comment.
/ping: @yeganer. Rest all of it looks logically correct to me. Please verify it once 🚀
There was a problem hiding this comment.
Sure. I'll make the necessary changes.
|
@wkerzendorf, @yeganer - can we merge this? |
unoebauer
approved these changes
Apr 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When --generate-references argument is used then path specified in
generate_referenceis used to generate reference data otherwise path of directory already containing the reference data is specified inreference. So instead of two fields, they are merged into one.gen_ref_pathandreference_filepathtoreference_filepath.referenceandgenerate_reference