-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TEP006] Aggregate TARDIS restructure and configuration system cleanup #652
Merged
wkerzendorf
merged 127 commits into
tardis-sn:master
from
ftsamis:restructure-aggregate
Dec 20, 2016
Merged
Changes from 120 commits
Commits
Show all changes
127 commits
Select commit
Hold shift + click to select a range
98f1250
Upgrade the model module to a python package.
ftsamis 0c400a8
Introduce the basics of the new model/base.py.
ftsamis 4bbd4b7
Add a dynamic density property to the new model.
ftsamis f74de3a
Add a volume and a no_of_shells property to the model.
ftsamis 9ea458a
Add a radius property to the Radial1DModel.
ftsamis 5a71008
Make t_radiative optional and initialize it accordingly to the legacy…
ftsamis 3e4a9ce
Add properties for getting the indexes of the v_boundaries to the Rad…
ftsamis 2847045
Add a model.density module and a model.base.from_config classmethod.
ftsamis 674ab30
Convert the model's v_boundaries to properties.
ftsamis d3872fd
Introduce Radial1DModel cutting to v_boundaries.
ftsamis 2968e63
Revert 'Add a model.density module' back to HomologousDensity.
ftsamis 797e611
Change Radial1DModel.density to respect the v_boundaries.
ftsamis 301584a
Change Radial1DModel.abundance to respect the v_boundaries.
ftsamis a601d2d
Allow model boundaries to be given as plain values.
ftsamis 56c9f07
New model.density module to hold HomologousDensity and density functi…
ftsamis d069be7
Change MontecarloRunner so it doesn't depend on a Configuration object.
ftsamis 7fdbb8d
Add a plasma parameter to MontecarloRunner.run
ftsamis 7f027bc
Move and adapt calculate_j_blues from the old Radial1DModel to Montec…
ftsamis 902dea8
Add the time_of_simulation property to the MontecarloRunner.
ftsamis 66f763b
Add the plasma as an argument to montecarlo.montecarlo_radial1d.
ftsamis 2123d61
Remove every Configuration object usage from the montecarlo.pyx
ftsamis 3a96b67
Add a from_config classmethod to the MontecarloRunner.
ftsamis 1e68a69
montecarlo.pyx: Access atomic_data from the plasma, instead of model.
ftsamis c03d951
Remove the legacy Radial1DModel.
ftsamis 3adf6f7
Replace LegacyPlasmaArray with a function.
ftsamis 3b18130
assemble_plasma: prepare() the atom_data before passing it to the pla…
ftsamis 4069a9b
Rename LTEJBlues to JBluesBlackBody
ftsamis 2690d6a
Add a JBluesDiluteBlackBody plasma property.
ftsamis bb725cd
Add a JBlueEstimator input plasma property.
ftsamis 48ad9cd
Remove JBlues as an Input plasma property.
ftsamis 134b715
Revert "Move and adapt calculate_j_blues from the old Radial1DModel t…
ftsamis 1907ede
Add a calculate_time_of_simulation and a calculate_luminosity_inner t…
ftsamis 2296737
Remove JBluesBlackBody from the nlte_properties collection.
ftsamis 0f48a0a
Check the radiative_rates_type to add the appropriate JBlues plasma m…
ftsamis 368790c
fixup! Add a JBluesDiluteBlackBody plasma property.
ftsamis 11c21b2
Change JBluesBlackBody's output name to j_blues from lte_j_blues.
ftsamis c770bf3
Improve JBluesBlackBody's calculate method by using intensity_black_b…
ftsamis 58e21eb
Implement the barebones of the restructured Simulation class.
ftsamis 10bf4ec
Implement the Simulation.from_config classmethod.
ftsamis ee24013
Make Simulation take the Montecarlo runner as a parameter.
ftsamis 0d7c472
Simulation: Add the logic for the last iteration.
ftsamis 1a604b2
Move the sigma_thomson calculation from config_reader to montecarlo.
ftsamis f58cd0a
Move the spectrum frequency calculation from config_reader to monteca…
ftsamis 43c780d
Remove supernova distance checking from config_dict
ftsamis 0fb355d
Don't rename virtual_spectrum_range's stop and num to end and samples.
ftsamis 1f5c11c
Add a FIXME note for supporting initialization of plasma properties.
ftsamis 355b16e
Fix and move the NLTE species conversions from config_reader to assem…
ftsamis 8971b58
model/density.py: Add support for all the specific density types.
ftsamis 606d534
Remove time_0 from a required property in specific densities.
ftsamis bc730cd
Add a time_0 property to the uniform density type.
ftsamis 285af6f
Add support for density files in the restructured Model.
ftsamis caa221a
Move the t_radiative calculation from config_reader to Model.from_con…
ftsamis d7f11d5
Properly pass the v_inner/outer_boundaries to the model, if proivded.
ftsamis f323371
Move the abundance calculations from config_reader to Radial1DModel.f…
ftsamis d6e002b
Move the t_inner calculation from config_reader to Radial1DModel
ftsamis 58653fa
Remove unneeded model related code from config_reader.
ftsamis 596c2ea
Simulation: Log the plasma state when advancing the simulation.
ftsamis 346e514
Fix a bug when initializing the logger for montecarlo/base.py
ftsamis 40f46bc
Make sure all no_of_packets variables are passed as integers.
ftsamis 15d8b77
Fix accessing the abundance array from the config in assemble_plasma.
ftsamis d6c3880
Remove unecessary imports from the config_reader.
ftsamis 30cda17
Make sure velocity and time_explosion are passed in CGS to the Model.
ftsamis 99ac69a
Fix invalid access of the structure section of the configuration.
ftsamis f429b4e
Remove atom_data from the init arguments of Simulation.
ftsamis ed504ce
Move the luminosity_nu_[start|end] calculation from config_reader to …
ftsamis d1bec3b
Move atom_data calculation from config_reader to assemble_plasma.
ftsamis 9cfc4ce
Don't duplicate information from the MontecarloRunner to the Simulation.
ftsamis 7c1151d
Add convergence checking and hold_iterations logic.
ftsamis 9a58984
Fix incorrect access of hold_iterations.
ftsamis 2c0b675
Remove all the unused code from config_reader.
ftsamis 9d48cf6
Properly set Configuration.config_dirname.
ftsamis f9a9a15
Initialize model's raw_velocity earlier.
ftsamis 1fbb69b
Reintroduce and adjust various to_hdf methods.
ftsamis fe6e2f0
Implement a basic callback system for calling a custom function after…
ftsamis 3df9525
assemble_plasma now takes an atom_data parameter as well.
ftsamis cacc66f
plasma conftest: Remove unused import.
ftsamis 2cf6830
Move test_quantity_linspace to test_util
ftsamis 1cff639
Remove two redundant configuration_namespace tests from test_config_r…
ftsamis 9928a61
Allow overriding model,plasma,runner in Simulation.from_config.
ftsamis 21b751d
Fix tests for simulation.
ftsamis 8d51913
Remove unused fixture from test_complete_plasmas.
ftsamis a2b4b3b
Remove commented out code from test_property_nlte.
ftsamis 77d0e89
Update test_plasmas_full to not use run_tardis.
ftsamis 898128d
Remove test_legacy_model_properties.
ftsamis 735a06d
Update test_tardis_full to use the post-restructure call interface.
ftsamis 012457c
Add back the check for invalid volume in read_density_file.
ftsamis 18810ef
Fix simulation trying to access hold_iterations value when convergenc…
ftsamis a02e83e
Make density array have the same length when read from a file as when…
ftsamis 0abc70b
Update test_ascii_readers to test the restructured code.
ftsamis d357b7d
Fix a parsing bug in read_simple_ascii_density
ftsamis baf655c
fixup! Update test_plasmas_full to not use run_tardis.
ftsamis 8e0bf33
Adjust io/tests/test_model_reader to the changed model_reader.
ftsamis 89c4ca3
Simplify test_config_reader, only testing the functions it provides.
ftsamis 06d77b0
Fix improperly accessing uniform density value in HomologousDensity f…
ftsamis 0c30093
Add a test module for model
ftsamis a91c72e
Allow initialization of modules in the BasePlasma.
ftsamis 72ffb02
fixup! Allow initialization of modules in the BasePlasma.
ftsamis ee52657
Remove the distinction of j_blues and lte_j_blues in the LevelBoltzma…
ftsamis 480b73e
Access nlte_species from nlte_data instead of plasma_parent.
ftsamis a795903
Change references to Radial1DModel.t_rads to t_rad.
ftsamis aa38a2f
Adjust the tardis script to the restructured code.
ftsamis 8ab42b6
Adjust run_tardis helper function to the restructured code.
ftsamis d9caf28
Move the j_blues properties from radiative_properties to a separate j…
ftsamis 6b32da7
Reintroduce j_blues_detailed as a ProcessingPlasmaProperty instead of…
ftsamis 5da19f2
Store some more montecarlo properties in the to_hdf method.
ftsamis 9857db8
Set the default path of Simulation.to_hdf to 'simulation'.
ftsamis eb23a45
Adjust test_integration.py to the restructured code.
ftsamis 9c40430
Skip test_plasma_simple.
ftsamis f5d5e39
Fix plasma properties accessing the plasma_parent. Also fix assemble_…
ftsamis e7c4a8d
Bring back storing the previous_properties in NLTE runs.
ftsamis 4b97676
Fix JBluesDetailed.__init__ method not accepting plasma_parent.
ftsamis e55f4d1
Fix not adding the detailed j_blues input properties to the plasma.
ftsamis 8929b5a
Fix JBluesDetailed.calculate accessing t_rad.value instead of just t_…
ftsamis 50fde00
Return a numpy.array in the JBluesDetailed.calculate method instead o…
ftsamis 1692e50
Use len(t_rad) instead of len(j_blues) in JBluesDetailed to represent…
ftsamis ea88f9d
Fix typo on parameter name of Simulation.to_hdf call from test_integr…
ftsamis 848a64e
Fix model.t_radiative not being cut to the specified v boundaries.
ftsamis 450fc17
Fix slicing the t_radiative twice in the getter if it was initialized…
ftsamis 5640c5f
Fix a wrong check in Radial1DModel.t_radiative setter regarding bound…
ftsamis b85aea9
Fix the luminosity_inner hdf location in test_integration.
ftsamis 02506b9
Add docstrings for some classes and methods affected by the restructure.
ftsamis 329564b
Fix a PEP8 violation in model_reader.
ftsamis c3b7550
Rename the after_time method of HomologousDensity to calculate_densit…
ftsamis d3f5946
Use the return statement once in HomogolousDensity.from_config instea…
ftsamis 782a0ab
Remove an outdated TODO comment.
ftsamis 136f667
Use sigma_T from astropy constants instead of hardcoding it, also fix…
ftsamis 1c79c5e
Revert "Use sigma_T from astropy constants instead of hardcoding it, …
ftsamis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will break existing scripts which expect that radial1d_mdl is returned by run_tardis.
I am tempted to swallow this and will update e.g. tardisanalysis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true, although having the entire simulation object returned is much more useful and takes the need to duplicate information, which we heavily did until now, i.e. copying various stuff to model.
So, swallowing this would be a fair trade-off, I believe. ☺