Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest-html==1.10.0, modify DokuReport class accordingly. #642

Merged
merged 2 commits into from
Aug 19, 2016

Conversation

kdexd
Copy link

@kdexd kdexd commented Aug 6, 2016

This PR reduces a chunk of code from DokuReport class as per the new version of pytest-html.

Latest Report

@@ -11,4 +11,3 @@ numexpr==2.4.4
Cython==0.21
networkx==1.10
pytest==2.6.3
pytest-html==1.8.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing a change here without providing a 'backup'. This is generally bad.

It is correct, that we consider conda-requirements obsolete but as long as they are included in our repository we should keep them updated, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for now please add the correct version to conda-requirements. We can discuss removing this file entirely in a new issue/PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Done

@kdexd kdexd changed the title Use pytest-html==1.9.0, modify DokuReport class accordingly. Use pytest-html==1.10.0, modify DokuReport class accordingly. Aug 19, 2016
@wkerzendorf wkerzendorf merged commit 7e52d3b into tardis-sn:master Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants