Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure the MontecarloRunner #636

Closed
wants to merge 15 commits into from
Closed

Restructure the MontecarloRunner #636

wants to merge 15 commits into from

Conversation

ftsamis
Copy link
Member

@ftsamis ftsamis commented Jul 26, 2016

This PR introduces the necessary changes to the MontecarloRunner in order to make it work with the restructured Radial1DModel.

@ftsamis
Add a plasma parameter to MontecarloRunner.run
5f83ef5 
The MontecarloRunner now needs a separate reference to the plasma since the restructured Radial1DModel doesn't have the plasma as an attribute anymore.
@wkerzendorf
Copy link
Member

looking good.

@ftsamis
Copy link
Member Author

ftsamis commented Aug 4, 2016

@wkerzendorf It doesn't. :( I realized that I need to change montecarlo.pyx as well because it uses the now gone model.tardis_config a lot.

Working on it now...

@yeganer
Copy link
Contributor

yeganer commented Aug 4, 2016

I think of MonteCarloRunner as the bridge between python and C. So all information that needs to be passed to the C should be available in the runner.
I don''t know if that makes sense but that's how I see it, do you agree/disagree?

@ftsamis
Copy link
Member Author

ftsamis commented Aug 4, 2016

@yeganer That's right, it already gets the model and the plasma, but montecarlo.pyx was accessing model.tardis_config which is no longer available. So the point now is changing those access attempts to the correct thing.

Should be relatively easy.

@ftsamis
Add the time_of_simulation property to the MontecarloRunner.
fc8da95
@ftsamis
Add the plasma as an argument to montecarlo.montecarlo_radial1d.
f777f8f
@ftsamis
Remove every Configuration object usage from the montecarlo.pyx
097454c
@ftsamis
Add a from_config classmethod to the MontecarloRunner.
894510c
@ftsamis
montecarlo.pyx: Access atomic_data from the plasma, instead of model.
f69c995
@ftsamis
Revert "Move and adapt calculate_j_blues from the old Radial1DModel t…
0e7cf7d 
…o MontecarloRunner."

This reverts commit 9f4385e, because it
was decided that the j_blues will become plasma properties.
@ftsamis
Add a calculate_time_of_simulation and a calculate_luminosity_inner t…
f410a60 
…o the MontecarloRunner.
@ftsamis
Move the sigma_thomson calculation from config_reader to montecarlo.
3895e14
@ftsamis
Move the spectrum frequency calculation from config_reader to monteca…
52071c8 
…rlo.
@ftsamis
Remove supernova distance checking from config_dict
790737c
@ftsamis
Don't rename virtual_spectrum_range's stop and num to end and samples.
931751e
@ftsamis ftsamis mentioned this pull request Aug 18, 2016
Merged
@ftsamis
Copy link
Member Author

ftsamis commented Sep 12, 2016

Closing in favor of #652.

@ftsamis ftsamis closed this Sep 12, 2016
@ftsamis ftsamis deleted the restructure-montecarlo branch December 20, 2016 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ftsamis @wkerzendorf @yeganer