Replace misused calls to yaml.load with a helper function. #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace yaml.load(open(filename))-like calls which didn't close the file after opening, with the helper functions yaml_load_file and yaml_load_config_file which properly parse a YAML file with the default yaml.Loader or with tardis.io.util.YAMLLoader respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the yaml.load operations looked like
yaml.load(open(filename)). Opening files and relying on the garbage collector to close them is a bad practice in Python.With this PR, I'm introducing
yaml_load_fileandyaml_load_config_fileintardis.io.utiland changing every call to yaml.load with the appropriate one of the above.This also makes sure that when loading a config file (by using
yaml_load_config_file), quantities are parsed from theYAMLLoaderas astropy Quantity objects and opens the way for the new validator to work with the pytest tests (since it won't accept strings for quantity type properties).