Organize headers in C-Extension #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Header files should only contain includes that are necessary for the compiler to understand the header. Includes needed by the implementation should be included by the corresponding source. With this philosophy in mind the includes in all c files were reorganized. As part of this reorganization the header `cmontecarlo1.h` was removed and it's declaration moved to `cmontecarlo.h` Resolves: tardis-sn#489
yeganer
force-pushed
the
organize_c_headers
branch
from
cb5dddf
to
ca82a9f
Compare
|
@chvogl your comments would be interesting. I'm fine to merge this as this is only of cosmetic nature. |
|
@chvogl @wkerzendorf Since these changes affect mostly imports I'd be happy to help resolve any merge conflicts arising from this change. |
|
@wkerzendorf No objections on my account. Fire away! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Header files should only contain includes that are necessary for the
compiler to understand the header. Includes needed by the implementation
should be included by the corresponding source.
With this philosophy in mind the includes in all c files were
reorganized.
As part of this reorganization the header
cmontecarlo1.hwas removedand it's declaration moved to
cmontecarlo.hResolves: #489