Plasma restructure

[wkerzendorf]

Very extensive restructure of the plasma calculation.

[landscape-bot]

Repository health decreased by 1% when pulling 95a067f on plasma/restructure into 8122c70 on master.

• 75 new problems were found (including 8 errors and 43 code smells).
• 5 problems were fixed (including 0 errors and 5 code smells).

[landscape-bot]

Repository health decreased by 1% when pulling 871caa5 on plasma/restructure into 8122c70 on master.

• 75 new problems were found (including 8 errors and 43 code smells).
• 5 problems were fixed (including 0 errors and 5 code smells).

[landscape-bot]

Repository health decreased by 1% when pulling 050997f on plasma/restructure into 8122c70 on master.

• 75 new problems were found (including 8 errors and 43 code smells).
• 5 problems were fixed (including 0 errors and 5 code smells).

[landscape-bot]

Repository health decreased by 1% when pulling 0ac6a94 on plasma/restructure into 8122c70 on master.

• 75 new problems were found (including 8 errors and 43 code smells).
• 5 problems were fixed (including 0 errors and 5 code smells).

[landscape-bot]

Repository health decreased by 1% when pulling 815092d on plasma/restructure into 8122c70 on master.

• 75 new problems were found (including 8 errors and 43 code smells).
• 5 problems were fixed (including 0 errors and 5 code smells).

[aoifeboyle]

@wkerzendorf I've finished adding the tests I wanted and I'd be happy to merge now.

[wkerzendorf]

@aoifeboyle we need to rebase

[aoifeboyle]

Ok @wkerzendorf I can do it I think

[wkerzendorf]

@ssim this is a massive merge - can you look at this as well.

[aoifeboyle]

@wkerzendorf Did you do the rebase?

[wkerzendorf]

I did a merge - but there seem to be problems. Can you check

[aoifeboyle]

Yeah sure

[wkerzendorf]

@aoifeboyle plasma_array also still exists in this branch.

[aoifeboyle]

@wkerzendorf did you just merge this? I removed some tests that still made use of functions in plasma_array and I'm still working through correcting them. But it should function fine if you merged it.

[wkerzendorf]

@aoifeboyle yep - more or less accidently. let's see how it goes. There is a revert PR. just make anew PR for your fixes.

[wkerzendorf]

you are number 3 behind vytas and myself