-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing benchmarks fix #2831
Failing benchmarks fix #2831
Conversation
*beep* *bop* 7 W291 [*] Trailing whitespace
2 W293 [*] Blank line contains whitespace
1 E999 [ ] SyntaxError: Expected an expression
Complete output(might be large): .github/workflows/benchmarks.yml:3:4: E999 SyntaxError: Expected an expression
.github/workflows/benchmarks.yml:20:5: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:81:49: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:111:81: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:112:54: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:199:1: W293 [*] Blank line contains whitespace
.github/workflows/benchmarks.yml:218:22: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:219:170: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:221:84: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:238:1: W293 [*] Blank line contains whitespace
Found 10 errors.
[*] 9 fixable with the `--fix` option.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2831 +/- ##
==========================================
- Coverage 70.89% 70.72% -0.18%
==========================================
Files 209 209
Lines 15589 15589
==========================================
- Hits 11052 11025 -27
- Misses 4537 4564 +27 ☔ View full report in Codecov by Sentry. |
e7523bc
to
781c419
Compare
* Remove extra asv installation step * Add conda build to list of dependencies alongside asv * change trigger temporarily for testing * Change conditonals too * Add conda as a dependency too * undo test modifications * pip asv
📝 Description
Type: 🪲
bugfix
| 🚀feature
| ☣️breaking change
| 🚦testing
| 📝documentation
| 🎢infrastructure
Benchmarks fail- https://github.com/tardis-sn/tardis/actions/runs/11105960403/job/30853255761?pr=2830
asv made a new release recently which requires conda-build if you use mamba to setup dependencies- https://github.com/airspeed-velocity/asv/releases/tag/v0.6.4
Benchmarks run- https://github.com/tardis-sn/tardis/actions/runs/11107154026/job/30857095092?pr=2831
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label