Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing benchmarks fix #2831

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Sep 30, 2024

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Benchmarks fail- https://github.com/tardis-sn/tardis/actions/runs/11105960403/job/30853255761?pr=2830

asv made a new release recently which requires conda-build if you use mamba to setup dependencies- https://github.com/airspeed-velocity/asv/releases/tag/v0.6.4

Benchmarks run- https://github.com/tardis-sn/tardis/actions/runs/11107154026/job/30857095092?pr=2831

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Sep 30, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (929b2d2).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

7	W291	[*] Trailing whitespace
2	W293	[*] Blank line contains whitespace
1	E999	[ ] SyntaxError: Expected an expression

Complete output(might be large):

.github/workflows/benchmarks.yml:3:4: E999 SyntaxError: Expected an expression
.github/workflows/benchmarks.yml:20:5: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:81:49: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:111:81: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:112:54: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:199:1: W293 [*] Blank line contains whitespace
.github/workflows/benchmarks.yml:218:22: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:219:170: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:221:84: W291 [*] Trailing whitespace
.github/workflows/benchmarks.yml:238:1: W293 [*] Blank line contains whitespace
Found 10 errors.
[*] 9 fixable with the `--fix` option.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.72%. Comparing base (de4d872) to head (929b2d2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2831      +/-   ##
==========================================
- Coverage   70.89%   70.72%   -0.18%     
==========================================
  Files         209      209              
  Lines       15589    15589              
==========================================
- Hits        11052    11025      -27     
- Misses       4537     4564      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atharva-2001 atharva-2001 marked this pull request as ready for review September 30, 2024 13:18
@andrewfullard andrewfullard merged commit 513cd06 into tardis-sn:master Sep 30, 2024
16 of 18 checks passed
CePowers pushed a commit to CePowers/tardis that referenced this pull request Oct 1, 2024
* Remove extra asv installation step

* Add conda build to list of dependencies alongside asv

* change trigger temporarily for testing

* Change conditonals too

* Add conda as a dependency too

* undo test modifications

* pip asv
@atharva-2001 atharva-2001 mentioned this pull request Oct 7, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants