-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small continuum iteration fix #2815
base: master
Are you sure you want to change the base?
Conversation
*beep* *bop* 7 G004 [ ] Logging statement uses f-string
1 RET505 [ ] Unnecessary `else` after `return` statement
1 RET506 [ ] Unnecessary `else` after `raise` statement
1 I001 [*] Import block is un-sorted or un-formatted
1 E902 [ ] No such file or directory (os error 2)
1 UP008 [*] Use `super()` instead of `super(__class__, self)`
1 TRY300 [ ] Consider moving this statement to an `else` block
Complete output(might be large): .github/workflows/codespell.yml:1:1: E902 No such file or directory (os error 2)
tardis/simulation/base.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/simulation/base.py:155:14: UP008 Use `super()` instead of `super(__class__, self)`
tardis/simulation/base.py:199:13: RET506 Unnecessary `else` after `raise` statement
tardis/simulation/base.py:263:17: G004 Logging statement uses f-string
tardis/simulation/base.py:270:9: RET505 Unnecessary `else` after `return` statement
tardis/simulation/base.py:451:13: G004 Logging statement uses f-string
tardis/simulation/base.py:549:13: G004 Logging statement uses f-string
tardis/simulation/base.py:656:25: G004 Logging statement uses f-string
tardis/simulation/base.py:659:13: G004 Logging statement uses f-string
tardis/simulation/base.py:664:13: G004 Logging statement uses f-string
tardis/simulation/base.py:715:13: TRY300 Consider moving this statement to an `else` block
tardis/simulation/base.py:717:26: G004 Logging statement uses f-string
Found 13 errors.
[*] 1 fixable with the `--fix` option (1 hidden fix can be enabled with the `--unsafe-fixes` option).
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2815 +/- ##
==========================================
- Coverage 70.96% 70.79% -0.18%
==========================================
Files 209 209
Lines 15638 15638
==========================================
- Hits 11098 11071 -27
- Misses 4540 4567 +27 ☔ View full report in Codecov by Sentry. |
📝 Small fixes to the way the plasma is updated for successive iterations when running with NLTE and continiuum
Type: 🪲
bugfix
The plasma update in the Simulation currently does not update the correct plasma properties and uses the wrong variable names for accessing the continuum estimators. Running a model with NLTE/continuum with reveal this if run for more than 1 iteration. This PR attempts to fix it.
Also, link issues affected by this pull request by using the keywords:
close
,closes
,closed
,fix
,fixes
,fixed
,resolve
,resolves
orresolved
.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label