Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed scatter function from interaction.py #2110

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

sonachitchyan
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Scatter function is not used in the interaction.py, this PR removes that.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #2110 (8b73a12) into master (b0b04ee) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2110      +/-   ##
==========================================
+ Coverage   61.33%   61.50%   +0.16%     
==========================================
  Files          75       75              
  Lines        8602     8611       +9     
==========================================
+ Hits         5276     5296      +20     
+ Misses       3326     3315      -11     
Impacted Files Coverage Δ
tardis/montecarlo/montecarlo_numba/interaction.py 28.36% <ø> (+0.36%) ⬆️
...dis/montecarlo/montecarlo_numba/formal_integral.py 53.87% <0.00%> (ø)
tardis/simulation/base.py 83.85% <0.00%> (+0.22%) ⬆️
tardis/montecarlo/montecarlo_numba/base.py 31.35% <0.00%> (+0.84%) ⬆️
tardis/io/logger/logger.py 75.86% <0.00%> (+5.17%) ⬆️
tardis/montecarlo/montecarlo_numba/r_packet.py 61.53% <0.00%> (+11.53%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@sonachitchyan sonachitchyan marked this pull request as ready for review August 3, 2022 12:43
@wkerzendorf wkerzendorf merged commit a97d35c into tardis-sn:master Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants