Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-produced PR 1826 #2104

Merged

Conversation

andrewfullard
Copy link
Contributor

📝 Description

Type: 🚦 testing

A simple re-upload of Jenny's PR to add tests for the custom abundance widget, because rebasing wasn't working as intended.

📌 Resources

see #1826

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Co-authored-by: Jenny Yu [email protected]

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #2104 (077c01b) into master (6269996) will increase coverage by 3.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2104      +/-   ##
==========================================
+ Coverage   58.13%   61.33%   +3.19%     
==========================================
  Files          75       75              
  Lines        8602     8602              
==========================================
+ Hits         5001     5276     +275     
+ Misses       3601     3326     -275     
Impacted Files Coverage Δ
tardis/visualization/widgets/custom_abundance.py 59.53% <0.00%> (+42.96%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andrewfullard andrewfullard marked this pull request as ready for review July 22, 2022 16:21
Copy link
Member

@jaladh-singhal jaladh-singhal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving it based on test pipelines and coverage pipeline's log. Don't remember the inner workings of CAW.

@andrewfullard to add Jenny as co-author we need to put the "co-authored by ..." in commit message. Could you please push an empty commit by doing so? OR remember to add it in commit message while doing squash and merge?

@andrewfullard andrewfullard enabled auto-merge (squash) July 25, 2022 15:24
@andrewfullard andrewfullard merged commit b0b04ee into tardis-sn:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants